chore(deps): bump go-logr/logr to v1.2.4#46
Open
moralpriest wants to merge 1 commit into
Open
Conversation
Replace vendored pre-release v1.0.0-rc1 with stable v1.2.4. - Self-contained, no new requires, go 1.16 (<= go 1.17 directive) - Logger interface (Enabled/Info/Error/V/WithName/New/Discard) unchanged - logr.Discard() preserved; zapr adapter (requires logr v1.1.0) compatible - Adds funcr/ testing sink (unused by DERO) + subpackages - Verified: go build ./... green, derod --testnet starts and logs via zapr->logr wiring (CORE/MEMPOOL/REGPOOL loggers)
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendored dependency bump (prep for eventual Go toolchain bump). Replaces the pre-release
v1.0.0-rc1ofgithub.com/go-logr/logrwith the stablev1.2.4.go-logr/logris the structured-logging interface used by all 21 DERO components (CORE,MEMPOOL,REGPOOL,p2p,wallet,miner,explorer,xswd, etc.). Each component declaresvar logger logr.Loggerand gets the zap-backed logger viaglobals.Logger.WithName(...). The concrete backend (zap) is bridged throughgo-logr/zapratglobals/globals.go:182. This bump modernizes the interface only — no behavior change.Why this is safe (one-at-a-time dep bump)
requiredirectives; go directive is1.16(<= ourgo 1.17). Clean standalone PR.Loggerinterface (Enabled/Info/Error/V/WithName/New) andlogr.Discard()are unchanged between rc1 and v1.2.4 (stabilized at v1.0.0).go-logr/zaprgo.mod already requireslogr v1.1.0— v1.2.4 is backward-compatible, so no zapr bump needed.funcr/package (a built-in test LogSink, unused by DERO) +testing/,testr/,examples/subpackages and their tests.Verification
go build ./...— green (exit 0).go vet ./globals/... ./blockchain/...— only pre-existing unreachable-code warnings (idiom, untouched).derod+dero-miner, randerod --testnet. The logr->zapr wiring works —CORE/MEMPOOL/REGPOOLloggers emit INFO/DEBUG viaWithNameandV(n).Not consensus-critical (logging interface only); no PoW impact.
Notes / follow-ups
go-logr/zapr v1.3.0, etc.) or the final go-directive bump.