chore(deps): bump mattn terminal family and fatih/color#48
Open
moralpriest wants to merge 1 commit into
Open
Conversation
Vendored dependency bumps (prep for eventual Go toolchain bump). - github.com/mattn/go-isatty: v0.0.20 (go 1.15) - github.com/mattn/go-colorable: v0.1.13 (go 1.15) - github.com/mattn/go-runewidth: v0.0.16 (go 1.9) - github.com/fatih/color: v1.18.0 (go 1.17, latest go<=1.17) fatih/color couples the three mattn deps, so they bump together. Used by: dero-wallet-cli / readline (terminal width, color output, isatty detection in walletapi/balance_decoder.go). Verification: - go build ./... green; all cmd binaries build (derod, dero-wallet-cli, dero-miner, explorer, simulator, pong_server) - go test ./...: only pre-existing failure Test_Payload_TX (walletapi tx_payload_test.go:168 Failed receiver balance check) — reproduced identically on clean community-dev worktree. Unrelated to terminal deps (color/isatty/runewidth do not affect TX balance math).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendored dependency bumps (prep for eventual Go toolchain bump). Terminal I/O family used by dero-wallet-cli / readline and color output:
fatih/color depends on mattn/go-colorable + mattn/go-isatty, so all three bump together.
Used by: readline (terminal width / isatty detection) and
walletapi/balance_decoder.go(isatty). Allgo <= 1.17— clean standalone PRs.Verification
go build ./...green; all cmd binaries build (derod, dero-wallet-cli, dero-miner, explorer, simulator, pong_server).go test ./...: the only failure isTest_Payload_TX(walletapi/tx_payload_test.go:168Failed receiver balance check) — pre-existing, reproduced identically on a clean community-dev worktree. Terminal deps (color/isatty/runewidth) do not affect TX balance math.Follow-ups
Remaining go<=1.17 vendored-dep candidates: bbolt, cbor, metrics (VictoriaMetrics+histogram), env, go-colorful, pkg/profile, kcp-go, robfig/cron. (cespare/xxhash deferred as consensus-critical; tjfoc/gmsm unused; blang/semver + go.uber.org/atomic already at latest; go-logr/zapr deferred until logr v1.2.4 / PR #46 lands.)