chore(deps): bump VictoriaMetrics/metrics to v1.38.0 (+ histogram, fastrand)#51
Open
moralpriest wants to merge 1 commit into
Open
Conversation
…strand) Vendored dependency bumps (prep for eventual Go toolchain bump). - github.com/VictoriaMetrics/metrics: v1.38.0 (go 1.17, latest go<=1.17) - github.com/valyala/histogram: v1.2.0 (go 1.12) — required by metrics - github.com/valyala/fastrand: v1.1.0 (no go directive; old format) — TRANSITIVE: metrics v1.38.0 histogram.go uses fastrand.RNG.Seed, which only exists in fastrand v1.1.0. Note: metrics v1.38.0 go.mod also lists golang.org/x/sys v0.15.0, but that is only imported by process_metrics_windows.go (build-tagged windows-only), so it is not needed for the Linux build. Verification: - go build ./... green (after adding fastrand v1.1.0 for the Seed API). - go test ./...: metrics own suite + importers pass. Only pre-existing failure is Test_Payload_TX (walletapi, reproduced on clean community-dev). - derod --testnet starts, logs cleanly (no errors/panics).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendored dependency bumps (prep for eventual Go toolchain bump).
fastrand.RNG.Seed, which only exists in fastrand v1.1.0.All
go <= 1.17— clean standalone PR.Why the extra two deps
metrics v1.38.0 declares
require valyala/histogram v1.2.0and its histogram.go usesfastrand.RNG.Seed(only in fastrand v1.1.0). Both are pulled in to keep the build green. metrics v1.38.0 also listsgolang.org/x/sys v0.15.0, but that is imported only byprocess_metrics_windows.go(windows-only build tag) — not needed for the Linux build.Verification
go build ./...green (after adding fastrand v1.1.0 for the Seed API).go test ./...: metrics own suite + importers pass. Only pre-existing failure isTest_Payload_TX(walletapi, reproduced identically on clean community-dev).derod --testnetstarts, logs cleanly (no errors/panics).Follow-ups
Remaining go<=1.17 vendored-dep candidates: env, go-colorful, pkg/profile, kcp-go, robfig/cron. (cespare/xxhash deferred as consensus-critical; tjfoc/gmsm unused; blang/semver + go.uber.org/atomic already at latest; go-logr/zapr deferred until logr v1.2.4 / PR #46 lands.)