Tools: git-subsystems-split: do not label a subject twice - #33889
Merged
peterbarker merged 1 commit intoJul 31, 2026
Merged
Conversation
build_template() removes one prefix from a subject before substituting the subsystem in, so a subject which already named the subsystem after its prefix ended up labelled twice: relabelling AP_HAL: hwdef: avoid shlex when splitting simple hwdef lines for the hwdef subsystem gave "hwdef: hwdef: avoid shlex ...". Collapse a repeated label when filling the template in, in both the place which predicts a new subject for the plan and the place which writes the message of a commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-project-automation
Bot
moved this from ReadyForDevCall
to Done
in Peter's ArduPilot 4.8 Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git subsystems-splitlabelled a commit subject twice when the subject already named the new subsystem after its own prefix, producing subjects likehwdef: hwdef: avoid shlex when splitting simple hwdef lines.Classification & Testing (check all that apply and add your own)
Against the subjects the substitution has to cope with, checking both the ones
which should collapse and the ones which must be left alone:
hwdefAP_HAL: hwdef: avoid shlex when splitting simple hwdef lineshwdef: avoid shlex when splitting simple hwdef lineshwdefAP_HAL_ChibiOS: hwdef: compile the pin-type regex oncehwdef: compile the pin-type regex oncehwdefhwdef: hwdef: hwdef: already trebledhwdef: already trebledhwdefno colon in this subjecthwdef: no colon in this subjecthwdefhwdef:hwdef:ToolsTools: build_script_base: drop redundant Linux boardsAP_HALAP_HAL: hwdef: avoid shlexRoverRover: fix a thinghwdefhwdef: hwdefs are greatDescription
Tool was fixed to not stuff up the commit lines....
AI assistance disclosure
This change was written with AI assistance (Claude). The AI wrote the patch, the
commit message, and this description, and ran the manual testing described above.
I have reviewed the change and am responsible for it.