Wrap Mattermost WebSocket events processing with watchdog and log#674
Draft
hloeung wants to merge 1 commit into
Draft
Wrap Mattermost WebSocket events processing with watchdog and log#674hloeung wants to merge 1 commit into
hloeung wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a watchdog wrapper around Mattermost websocket event handling to emit a warning when an individual event handler runs longer than 5 seconds, and ensures the per-worker channel-update ticker is stopped on exit.
Changes:
- Added
executeWithWatchdogto wrap websocket event handler execution with a 5-second warning timer. - Routed websocket event handler calls through
executeWithWatchdogto standardize long-running handler logging. - Stopped the
updateChannelsThrottleticker viadeferto avoid leaking ticker resources when workers exit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+143
to
+153
| creationStack := debug.Stack() | ||
| timer := time.AfterFunc(5*time.Second, func() { | ||
| logger.Warnf("CRITICAL WARNING: Worker handling '%s' has been running for >5s! "+ | ||
| "Event Details: ChannelId=%s, UserId=%s, EventType=%s\n%s", | ||
| label, | ||
| rawEvent.GetBroadcast().ChannelId, | ||
| rawEvent.GetBroadcast().UserId, | ||
| rawEvent.EventType(), | ||
| string(creationStack), | ||
| ) | ||
| }) |
hloeung
changed the title
hloeung
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for receiving of Mattermost events via the WebSocket and processing by matterircd.
#677 is for handling of events and sending IRC messages to clients connect to matterircd.