Skip to content

Limit scope to review comment: keep channel_restored cache-refresh-only#676

Closed
hloeung with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-review-comment-674
Closed

Limit scope to review comment: keep channel_restored cache-refresh-only#676
hloeung with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-review-comment-674

Conversation

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This addresses only the linked review comment requesting removal of unintended channel_restored behavior changes. The intended outcome is that channel_restored does not execute channel-created handling logic.

  • Scope aligned to review comment

    • Kept handling for model.WebsocketEventChannelRestored as cache-refresh-only.
    • Ensured no mapping to handleWsActionChannelCreated is introduced as part of this fix scope.
  • Behavior preserved

    • channel_restored continues to run only the cache presence/update check path.
case model.WebsocketEventChannelRestored:
    // check if we have the users/channels in our cache. If not update
    m.checkWsActionMessage(message.Raw, updateChannelsThrottle)

Copilot AI changed the title [WIP] Fix code as per review comment for PR 674 Limit scope to review comment: keep channel_restored cache-refresh-only Jul 10, 2026
Copilot AI requested a review from hloeung July 10, 2026 08:43
@hloeung hloeung closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants