Wrap events and IRC messages to clients watchdog and log#677
Draft
hloeung wants to merge 7 commits into
Draft
Conversation
hloeung
force-pushed
the
blocking-channel
branch
from
8240c53 to
9d4041e
Compare
hloeung
force-pushed
the
blocking-channel
branch
from
dd3c594 to
ec78f16
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent worker deadlocks caused by blocking channel sends in the IRC decode pipeline and Mattermost websocket event handling, and also addresses ticker lifecycle cleanup.
Changes:
- Ensure long-lived tickers are stopped via
defer ...Stop()to avoid ticker leaks. - Update IRC decode buffering to use a bounded buffer and guarded sends to reduce blocking.
- Introduce
safeEventSendfor Mattermost event dispatch and route several websocket event paths through it.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| mm-go-irckit/userbridge.go | Stops the per-call throttle ticker to avoid leaking ticker resources. |
| mm-go-irckit/user.go | Adds a bounded paste buffer and a timeout-guarded send path to avoid blocking on DecodeCh. |
| bridge/mattermost/mattermost.go | Stops the channel-update ticker; introduces safeEventSend and uses it in several event dispatch points. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hloeung
force-pushed
the
blocking-channel
branch
from
e7dbb7c to
80ea241
Compare
hloeung
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for handling of events and sending IRC messages to clients connect to matterircd.
#674 is for receiving of Mattermost events via the WebSocket and processing by matterircd.