Repository navigation
feat(web): empty-turn indicator in place of the per-turn divider (ZOD076) - #59
Merged
Merged
Conversation
…076) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zooidbot
commented
Oct 14, 2026
zooidbot
left a comment
Collaborator
Author
There was a problem hiding this comment.
Lead review against the ZOD076 plan: no blocking findings.
- The decoder accepts
produced_outputonly as a real boolean. The"false"string case is tested. - Only
producedOutput === falserenders. The per-turn "TURN ENDED" divider is gone, which is intended (spec: one marker per turn is the noise to avoid). EmptyTurnIndicatormatches the Contracts: sentence-case fact, the exact tooltip sentence as a shared constant, the stop reason as a second line, a focusable<button>, and no icon or alert colour.- The scene story is in
ThreadView, which is right becauseturn.endalways carriesm.thread. UX Tester passed all five stories in both themes.
Merges after zooid#141 once CI is green.
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs zooid-ai/zooid#16 (not a closing keyword: Lead closes it once both PRs are merged).
Web half of ZOD076. Companion zooid PR: zooid-ai/zooid#141 (adds
turn_id/stop_reasontodev.zooid.turn.end). Merge that one first.decodeZooidEventreadsproduced_output(boolean only),turn_idandstop_reason(strings only); junk types decode toundefined.EmptyTurnIndicator: " ended its turn without output", neutral muted rule, focusable trigger, tooltip with the ambiguity sentence plusStop reason: <x>when present.turn.endrenders the indicator only whenproducedOutput === false. Any other turn.end (output, or an older daemon with no field) renders nothing, which removes the per-turn "TURN ENDED" divider. Intended.Timeline/EmptyTurnIndicator(Default, NoStopReason, LongAgentName, TooltipOpen) andStructures/ThreadViewEmptyTurn(SilentThenAnswered).Tests:
pnpm -C packages/web test997 passed (155 files); typecheck clean; build OK. UX Tester: ✅ all five stories, light and dark, console clean (no errors or React warnings).Not verified: the indicator in the full real app (Smoke Tester serves the published @zooid/web, not this branch); that's Ori's manual check after release. No
lintscript exists in packages/web, so lint wasn't run.Knowledge impact: ZOD076 (shipped by this pair); ZNC025 (the per-turn "TURN ENDED" divider is gone)
Plan feedback: Phase 0 says branch in Ori's clones, read-only for Coding, so I used worktrees. The plan didn't say
Dividerstays (still used bysession.start); I checked as Step 3.5 advised. Radix tooltips needTooltipProviderin stories and tests; the plan covered that well. The plan never mentions that issue #16 was in Backlog, not Ready.🤖 Generated with Claude Code