Repository navigation
Conversation
zjncs
force-pushed
the
feat/authoring-runtime
branch
from
October 12, 2026 03:25
fc75d54 to
f1ebf3c
Compare
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
from
October 12, 2026 03:27
73871fd to
6fe094f
Compare
zjncs
force-pushed
the
feat/authoring-runtime
branch
from
October 13, 2026 13:03
f1ebf3c to
d47fa5a
Compare
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
from
October 13, 2026 13:03
6fe094f to
d47fa5a
Compare
zjncs
force-pushed
the
feat/authoring-runtime
branch
from
October 14, 2026 14:22
d47fa5a to
921dc03
Compare
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
from
October 14, 2026 14:22
42bfae1 to
921dc03
Compare
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
from
October 14, 2026 14:45
7826966 to
65c048d
Compare
zjncs
force-pushed
the
feat/authoring-runtime
branch
from
October 14, 2026 14:55
140f9d9 to
b63c92d
Compare
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
2 times, most recently
from
October 14, 2026 15:08
fa41aef to
b03d08d
Compare
zjncs
force-pushed
the
feat/authoring-runtime
branch
2 times, most recently
from
October 15, 2026 06:13
547cf08 to
ca41950
Compare
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
from
October 15, 2026 06:13
b03d08d to
cb73e2f
Compare
zjncs
force-pushed
the
feat/authoring-runtime
branch
from
October 15, 2026 16:56
6e38cfc to
cf50f0f
Compare
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
from
October 15, 2026 16:58
cb73e2f to
397b1ff
Compare
zjncs
force-pushed
the
feat/authoring-runtime
branch
from
October 17, 2026 03:37
cf50f0f to
831e58d
Compare
Layer (c) of the authoring platform (iflytek#934), stacking on the runtime layer: - **Fix loop**: apply a finding's suggested patch to the draft in one call (sha256-guarded old content, revision bump, validation verdict invalidated by the new revision) or dismiss it as not applicable - **Submission**: validated drafts submit into the existing SkillHub publish pipeline — the gate is strict (the draft's current revision must be bound to a run that succeeded with zero errors), so content can never be published without the exact bytes that were validated; reuses SkillPublishService (package re-validation, security scan, review flow) and records the resulting skill id on the draft Verified by the full authoring flow integration test: create → edit → bind runtime → three-layer validation → fix a finding → re-validate → submit into the (mocked) publish pipeline. Signed-off-by: zjncs <18910855655@163.com>
Adds the finding apply/dismiss and draft submit endpoints on top of the runtime-layer schema. Signed-off-by: zjncs <18910855655@163.com>
zjncs
force-pushed
the
feat/authoring-fix-publish
branch
from
October 17, 2026 03:38
397b1ff to
f646210
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer (c) of the authoring platform split (iflytek#934 on iflytek/skillhub), stacking on the runtime layer (fork PRs until iflytek#935 lands upstream).
What this layer adds
POST /runs/{id}/findings/{fid}/apply|dismiss)POST /drafts/{id}/submithands a validated draft to the existing SkillHub publish pipeline. The gate is strict: the draft's current revision must be bound to a validation run that succeeded with zero errors, so content can never be published without the exact bytes that were validated. ReusesSkillPublishService(package re-validation, security scan, review flow) and records the resulting skill id on the draft.Verification
AuthoringFlowIntegrationTest(Testcontainers PostgreSQL, mocked publish pipeline): create → edit files → bind runtime → three-layer validation → apply a suggested fix → revision bump + verdict invalidation → re-validate → submit. 9 files, +680 lines — the thinnest layer of the stack.