Repository navigation
Tracking issue for PR #886: Agent Skill authoring and validation platform (OSPP task 26d8e0076) #934
Copy link
Copy link
Open
Labels
effort/m中等改动,存在一定协同成本 / Medium change with noticeable coordination cost.中等改动,存在一定协同成本 / Medium change with noticeable coordination cost.priority/p1高优先级 / High priority triage bucket.高优先级 / High priority triage bucket.risk/high涉及安全、鉴权、迁移或公共契约 / Touches security, auth, migrations, or public contracts.涉及安全、鉴权、迁移或公共契约 / Touches security, auth, migrations, or public contracts.triage/core交由 core maintainer 结合 AI 协同处理 / Issue should be handled by a core maintainer with AI support.交由 core maintainer 结合 AI 协同处理 / Issue should be handled by a core maintainer with AI support.
Description
Summary
PR #886 implements the Agent Skill creation and validation platform for OSPP 2026 task 26d8e0076 (面向 SkillHub 的 Agent Skill 创建与验证平台). It closes the gap named in the task brief: users currently author skills by hand — this adds a unified draft → validate → fix → publish loop on top of SkillHub.
What the PR delivers
- Draft authoring: draft CRUD with scaffolded
SKILL.md, file editor with optimistic concurrency (expectedRevision), resource files - Runtime binding: local-script and OpenAI-compatible agents, tool allowlists; MCP server declarations (http/sse/stdio) with server-side probing during validation
- Three-layer validation: structure (SKILL.md rules) / config (binding, MCP reachability) / behavior (script + prompt tasks with assertions)
- Fix loop: findings with locations and suggested patches, diff preview, one-click apply (revision bump), re-validation history
- Publish integration: validated drafts submit into the existing pipeline (security scan → review → publish)
- Security: SSRF policy on OpenAI/MCP endpoints (cloud-metadata always blocked), stdio MCP off by default with docker isolation, envRefs allowlist; docker execution-mode default with startup guard
- RISC-V64: repeatable real-board CI on physical VisionFive 2 hardware (task requirement field: 支持架构 RISC-V64)
Verification evidence
- Backend: 1085 tests, 0 failures; live smoke 39/39 (
scripts/authoring-smoke-test.sh); publish-pipeline E2E 16/16 (scripts/authoring-publish-e2e.sh) - Real-board RISC-V64 CI (free board runners, fork-guarded workflow): authoring flow green 7 consecutive runs; full backend suite on the board BUILD SUCCESS — 1081 tests, 0 failures (green run)
- DCO ✅ / CLA ✅, MERGEABLE, rebased on the latest main; design doc
docs/26-skill-authoring-platform.md, example skill inexamples/skill-authoring/
Scale
19 commits, 150 files changed (+17.9k / −971) — larger than the usual PR here, we split it into 15 reviewable commits by layer.
Ask
The PR has been Ready with all checks green for several days. Could a maintainer take a look and advise on the review path? Happy to split it, — the mentor is cc'd (ylhu16@iflytek.com) in case the OSPP timeline needs it landed sooner.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
effort/m中等改动,存在一定协同成本 / Medium change with noticeable coordination cost.中等改动,存在一定协同成本 / Medium change with noticeable coordination cost.priority/p1高优先级 / High priority triage bucket.高优先级 / High priority triage bucket.risk/high涉及安全、鉴权、迁移或公共契约 / Touches security, auth, migrations, or public contracts.涉及安全、鉴权、迁移或公共契约 / Touches security, auth, migrations, or public contracts.triage/core交由 core maintainer 结合 AI 协同处理 / Issue should be handled by a core maintainer with AI support.交由 core maintainer 结合 AI 协同处理 / Issue should be handled by a core maintainer with AI support.
Activity
github-actions commentedon Oct 9, 2026
Issue Triage
triage/corepriority/p1(3.7/5)effort/m(3/5)3/5highrules-onlyWhy
High-Risk Signals
Maintainer Brief
Summary: PR #886 implements the Agent Skill creation and validation platform for OSPP 2026 task 26d8e0076 (面向 SkillHub 的 Agent Skill 创建与验证平台). It closes the gap named in the task brief: users currently author skills by hand — this adds a unified draft → validate → fix → publish loop on top of SkillHub.
Why core:
Reproduction or operator path:
Suspected areas:
Risks to watch:
Validation checklist:
Next Action
问题分流结果
triage/corepriority/p1(3.7/5)effort/m(3/5)3/5高rules-only原因
高风险信号
维护者交接摘要
概要: PR #886 implements the Agent Skill creation and validation platform for OSPP 2026 task 26d8e0076 (面向 SkillHub 的 Agent Skill 创建与验证平台). It closes the gap named in the task brief: users currently author skills by hand — this adds a unified draft → validate → fix → publish loop on top of SkillHub.
为何进入 core:
复现路径或操作路径:
怀疑影响区域:
重点风险:
验证清单:
下一步
FenjuFu commentedon Oct 10, 2026
Thanks for the detailed write-up and the RISC-V evidence. Given the size and the security-sensitive surface (endpoint probing, stdio MCP, docker execution), we'd like to review this in layers rather than as one 18k-line PR. Suggested path:
mainand renumber the migration:mainnow hasV66__promotion_update.sqlandV67__promotion_revocation_request.sql, so yours should becomeV68__authoring_platform.sql(that's the current conflict).riscv64-native.ymlin your fork. It can't run upstream since it needs the board runners, and linking the green runs from the docs is enough evidence for the RISC-V64 requirement.We'll start reviewing as soon as (a) is up. Keep #934 as the tracking issue and link each PR there.
zjncs commentedon Oct 10, 2026
Thanks @FenjuFu — that path works for us. Plan of record:
mainand renumber the migration toV68__authoring_platform.sql(noted the promotion migrations took V66/V67).riscv64-native.ymlstays fork-only; the docs link the green board runs (7× authoring flow + full suite BUILD SUCCESS) as the RISC-V64 evidence.We'll link PR (a) here as soon as it's up. Thanks again for taking a look!
zjncs commentedon Oct 10, 2026
Layer (a) is up: #935 — draft domain model + V68 migration + draft CRUD (scaffolded SKILL.md) + structure-layer validation with fix suggestions. 54 files, +4.0k lines; domain 609 tests green, draft-flow integration test (broken frontmatter → fixable finding → repair → SUCCEEDED) green, full suite running on the branch now.
Remaining layers (b)–(e) will stack on top of (a) and link here as they go.
zjncs commentedon Oct 10, 2026
Layer (b) — runtime bindings, MCP probing and the security policies — is stacked and ready for review: zjncs#1 (diff is the (b)-only slice, +5.7k lines on top of #935).
Since the stacked base branch lives on the fork until (a) merges, the PR is opened against the fork branch; it will be retargeted to upstream main as soon as #935 lands. Happy to move things around if you'd prefer a different arrangement.
Layers (c)–(e) coming up the same way.
zjncs commentedon Oct 10, 2026
The full stack is up. Layers and their diffs (each green on its own; the fork PRs will be retargeted to upstream main as #935 lands):
Verification per layer: (a) full suite 1049 tests 0 failures; (b) security/MCP/adapter unit tests + runtime-flow integration test (full suite re-run in progress, will report); (c) full suite 1105 tests 0 failures incl. the complete authoring flow; (d) typecheck + 922 web unit tests (only the two pre-existing upstream theme tests fail, identically on plain main); (e) docs/scripts only, scripts syntax-checked.
#886 (the monolithic PR) is superseded by this stack — closing it in favor of the layers above.
feat(authoring): draft domain model, CRUD and structure-layer validation
feat(authoring): runtime bindings, MCP probing and the security policies
feat(authoring): fix loop and publish-pipeline integration
feat(web): skill authoring workbench
docs(authoring): platform design doc, example skill and verification …
feat(authoring): runtime bindings, MCP probing and the security policies
docs(authoring): platform design doc, example skill and verification …
feat(authoring): runtime bindings, MCP probing and the security policies
docs(authoring): platform design doc, example skill and verification …
zjncs commentedon Oct 14, 2026
Status update:
ValidationRunOrchestratorTestpasses against the merged version)Heads-up on V69: with #935 merged,
V69__authoring_platform.sqlnow occupies V69 on main, so #947'sV69__skill_avatars.sqlwill need the renumber-and-rerun per the coordination plan.docs(authoring): platform design doc, example skill and verification …
docs(authoring): platform design doc, example skill and verification …
docs(authoring): platform design doc, example skill and verification …
feat(authoring): runtime bindings, MCP probing and the security policies
feat(authoring): fix loop and publish-pipeline integration
docs(authoring): platform design doc, example skill and verification …
feat(web): skill authoring workbench
feat(authoring): runtime bindings, MCP probing and the security policies
feat(authoring): runtime bindings, MCP probing and the security policies