Skip to content

enhance: Add service name differentiation for tracer #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
presburger wants to merge 1 commit into
base: 2.6
Choose a base branch
from
Open

enhance: Add service name differentiation for tracer #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/common/Tracer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ struct TraceConfig {
std::string otlpHeaders;
bool oltpSecure;

std::string clusterID;
int nodeID;
};

Expand Down
3 changes: 2 additions & 1 deletion src/common/Tracer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ initTelemetry(const TraceConfig& cfg) {
}
if (export_created) {
auto processor = trace_sdk::BatchSpanProcessorFactory::Create(std::move(exporter), {});
resource::ResourceAttributes attributes = {{"service.name", TRACE_SERVICE_SEGCORE}, {"NodeID", cfg.nodeID}};
auto service_name = cfg.clusterID + "-" + TRACE_SERVICE_SEGCORE;
resource::ResourceAttributes attributes = {{"service.name", service_name}, {"NodeID", cfg.nodeID}};
auto resource = resource::Resource::Create(attributes);
auto sampler = std::make_unique<trace_sdk::ParentBasedSampler>(std::make_shared<trace_sdk::AlwaysOnSampler>());
std::shared_ptr<trace::TracerProvider> provider =
Expand Down