enhance: Add service name differentiation for tracer - #113
Open
presburger wants to merge 1 commit into
Open
Conversation
Author
|
@czs007 help review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves trace identification when multiple Milvus clusters share the same Jaeger backend. The cluster identifier is passed through TraceConfig and prepended to the Segcore OpenTelemetry service name. As a result, the service name changes from segcore to -segcore, making it easy to filter and distinguish traces from different clusters in Jaeger while preserving the existing tracing and exporter behavior.
Note: Once this commit is merged, we will submit a corresponding follow-up commit to Milvus to pass the cluster identifier into milvus-common when initializing and resetting the Segcore tracing configuration.