Skip to content

Repository navigation

Show the playback notice when the browser can't draw the video #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zfleeman merged 1 commit into from
Oct 22, 2026
Merged

Show the playback notice when the browser can't draw the video #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ffmpeg4discord/templates/web.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,14 +358,18 @@ <h4>Audio Streams</h4>
}

// Browsers can't play some formats, like HEVC or ProRes. Some fail outright, and some load only the audio.
// Others, like Firefox with an HEVC MKV, report the video's size and play its audio but never draw a frame.
const playbackNotice = document.getElementById('playbackNotice');
function checkPlayable() {
if (video.error || (video.readyState >= HTMLMediaElement.HAVE_METADATA && video.videoWidth === 0)) {
const noFrames = !video.paused && video.getVideoPlaybackQuality().totalVideoFrames === 0;
if (video.error || (video.readyState >= HTMLMediaElement.HAVE_METADATA && video.videoWidth === 0) || noFrames) {
playbackNotice.hidden = false;
}
}
video.addEventListener('error', checkPlayable);
video.addEventListener('loadedmetadata', checkPlayable);
// A video that can be decoded has drawn frames within a second of playing
video.addEventListener('playing', () => setTimeout(checkPlayable, 1000));
checkPlayable(); // the video may have failed before this script ran

// The preview plays from the start time and stops at the end time, even after a pause or a speed change.
Expand Down
Loading