Repository navigation
Show the playback notice when the browser can't draw the video - #131
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web UI's "Your browser can't play this video" notice didn't appear for an HEVC MKV in Firefox. Firefox played the audio and reported the real 1920x1080 size, but the video stayed black. The old check only caught videos that fail to load or report a width of 0, so it missed this case.
The page now also checks
video.getVideoPlaybackQuality().totalVideoFramesone second after playback starts. If the video is still playing and no frames have been drawn, the browser can't decode it, so the notice appears.Testing
I played two pages for 3 seconds in headless Firefox 158 (driven with Selenium) and read the player's stats:
totalVideoFramesThe MKV needs #130 to open at all, so I ran this test on a temporary merge of both branches.
uv run pytest --covpasses (290 tests, 99.39%), andruffis clean. There are no JavaScript tests, so the browser run above is the only test of the change itself.