Repository navigation
Fix MKV crash and read the source audio bitrate from the first track - #130
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127 and #128. Both bugs were in the same few lines that read the input's audio bitrate.
KeyError: 'bit_rate'. When the bitrate is missing, ff4d now uses 96 kbps, the same as the-adefault (FALLBACK_AUDIO_BR)._parse_streams()remembered the last audio track's index, so a clip with game audio and a mic track took its default bitrate from the mic. ff4d now reads it fromself.audio_streams[0], so_parse_streams()no longer needs to return anything.The default bitrate only applies when no audio bitrate is set, for example a blank Audio Bitrate field in the web UI.
Testing
uv run pytest --cov: 292 passed, 99.39% coverage.ruff formatandruff checkare clean.-b:a 96000.