fix(ci): reconcile frozen lockfile config and force LF on text files - #28
Merged
Merged
Conversation
Two failures surfaced when 1.7.0 first ran through CI on main. pnpm install --frozen-lockfile failed with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH. pnpm-workspace.yaml carried a stray "allowBuilds: esbuild: set this to true or false" placeholder that pushed the resolved config out of sync with the lockfile. Removing it reconciles the two; the lockfile content itself is unchanged. cargo xtask check-bindings reported the generated TypeScript bindings as stale on the Windows runner. It compares frontend/src/generated/bindings.ts byte for byte before and after regeneration, and with no .gitattributes rule the file was checked out CRLF while the generator writes LF. "* text=auto eol=lf" forces LF on checkout everywhere so the byte compare matches. Verified locally: pnpm install --frozen-lockfile and cargo xtask check-bindings both pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two CI failures that surfaced when the 1.7.0 release commit first ran through Actions on main.
Root cause and fix
pnpm install --frozen-lockfilefailed withERR_PNPM_LOCKFILE_CONFIG_MISMATCH.pnpm-workspace.yamlcarried a strayallowBuilds: esbuild: set this to true or falseplaceholder that pushed the resolved pnpm config out of sync with the lockfile. Removing it reconciles the two; the lockfile content itself is unchanged.cargo xtask check-bindingsreported the generated TypeScript bindings as stale on the Windows runner. It byte-comparesfrontend/src/generated/bindings.tsbefore and after regeneration, and with no.gitattributesrule the file was checked out CRLF while the generator writes LF.* text=auto eol=lfforces LF on checkout everywhere so the byte compare matches.Proof
pnpm install --frozen-lockfileandcargo xtask check-bindingsboth pass.