fix(ci): put pnpm overrides in package.json for pnpm 9 - #29
Merged
Conversation
The esbuild override lived in pnpm-workspace.yaml, a location only pnpm 10+ reads. The repo pins pnpm@9.0.0 and CI runs it; pnpm 9 reads overrides from package.json pnpm.overrides. So pnpm 9 saw no current override while the lockfile recorded esbuild: 0.28.1, and pnpm install --frozen-lockfile failed with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH. Moving the override to package.json aligns the config pnpm 9 reads with the lockfile. Verified with CI=true and pnpm 9.0.0: install --frozen-lockfile, check, lint, build and test all pass. Lockfile unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second CI fix for the 1.7.0 release: the Frontend job still failed at
pnpm install --frozen-lockfile.Root cause and fix
The esbuild override lived in
pnpm-workspace.yaml, a location only pnpm 10+ reads. The repo pinspnpm@9.0.0and CI runs it; pnpm 9 reads overrides frompackage.jsonpnpm.overrides. pnpm 9 therefore saw no current override while the lockfile recordedesbuild: 0.28.1, trippingERR_PNPM_LOCKFILE_CONFIG_MISMATCH. Moving the override topackage.jsonaligns the config pnpm 9 reads with the lockfile.Proof
Reproduced and fixed with
CI=trueon pnpm 9.0.0:install --frozen-lockfile, check, lint, build and test all pass. The Rust job's check-bindings already passes on main after the.gitattributesLF fix (#28). Lockfile unchanged.