Repository navigation
doc: add i18n translations for Japanese - #5082
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds multi-language localization support to the project, introducing translated README files and documentation scaffolding for German, Spanish, French, Italian, Korean, Portuguese, and Traditional Chinese, alongside updates to the documentation build system. The reviewer feedback identifies that several reference-style links in the new README files are missing their definitions and should be converted to inline links. Additionally, the zh_TW locale should be included in the translate-po target within doc/Makefile to ensure its translations are correctly updated.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request significantly expands the project's localization by adding translated README files and documentation translation templates (.po files) for several languages, including German, Spanish, French, Italian, Korean, Portuguese, and Traditional Chinese. It also updates the documentation build system and language switcher, and introduces a script to scaffold new locales. The review comments are accurate and should be addressed: one identifies a reStructuredText formatting issue in the German translation where literal block markers (::) were incorrectly modified, and the other suggests using catalog.obsolete.clear() for a cleaner implementation in the locale initialization script.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces multi-language documentation support for several new locales (German, Spanish, French, Italian, Korean, Portuguese, and Traditional Chinese). It adds translated README files, updates the documentation Makefile and static switcher to support these locales, and adds a Python script (init_locales.py) to scaffold .po files from the zh_CN template. A bug was identified in doc/source/init_locales.py where overwriting message.string with a single empty string for plural messages causes invalid PO syntax. A code suggestion was provided to preserve the list/tuple structure for plural messages.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
qinxuye
changed the title
e2b2cd4 to
b42fd23
Compare
kejhz653-stack
changed the title
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Please review this pr @qinxuye .Thanks！ |
Use bundled switcher.json per locale build, localize external links, and tighten header CSS so translated nav labels stay on one row.
Bring in unified switcher.json, locale-aware navbar labels, and Read the Docs mo compilation helpers from feat/docs-i18n-de. Co-authored-by: Cursor <cursoragent@cursor.com>
Initialize switcher options defensively in config-inited, move mo compilation and zh_cn tagging into setup(app), and remove header-level fuzzy markers from ja/zh_CN catalogs after quality checks passed. Co-authored-by: Cursor <cursoragent@cursor.com>
cdfe3ca to
bb6c64d
Compare
Restore all Simplified Chinese .po files to upstream main so this PR only carries non-zh_CN i18n work.
3 participants
Summary
init_locales.pyscaffold script for generating locale PO file structure.doc/Makefilewithhtml_jabuild target.switcher.jsonwith the Japanese language entry and RTD URL.Preview
Test plan