Repository navigation
doc: add German (de) documentation translations - #5105
Conversation
kejhz653-stack
added
the
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds German translations (.po files) for various documentation pages of Xinference, covering development guides, examples, model descriptions, and getting started tutorials. The reviewer identified several translation issues, including missing translations (empty msgstr entries), incorrect translations (such as translating 'Introduction' as 'N/A' or 'Introduktion' instead of 'Einführung', and 'Image usage' as 'Verwenden Sie das Spiegelbild'), typographical errors, and inconsistent forms of address (formal 'Sie' vs. informal 'du'). Additionally, there are issues with incorrectly localized links pointing to Chinese documentation or .cn domains instead of the global .io site, as well as incorrect punctuation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
4196a0d to
3161ea8
Compare
|
/Gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds German translations (PO files) for the Xinference documentation, covering development guides, examples, getting started instructions, and model details. The reviewer identified several translation issues that need to be addressed, including machine translation artifacts (such as 'Hier ist die Übersetzung:' and English hallucinations), a hallucinated Python code block instead of a text translation, incorrect links pointing to Chinese instead of German guides, full-width Chinese colons, incorrect terminology (e.g., translating 'endpoints' as 'Ports' instead of 'Endpunkte'), grammatical gender mismatches, and missing translations.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds German localization files (.po) for the Xinference documentation. The reviewer identified several translation issues, including copy-paste errors, incorrect terminology (such as translating "Transcription API" as "Übersetzungs-API"), singular/plural mismatches, broken links, untranslated paragraphs, and inconsistent heading punctuation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds German translations (.po files) for various documentation files in Xinference, including guides on installation, logging, virtual environments, and model usage. The review feedback is highly constructive, pointing out several translation issues such as grammatical and stylistic errors in headings, incorrect parts of speech, number mismatches (translating plurals as singulars), and omitted sentences. Additionally, the feedback correctly identifies the accidental use of Chinese full-width punctuation in German text, the introduction of unnecessary literal translations, and broken Sphinx syntax caused by translating the double colon literal block marker (::) as a single colon (:).
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
157843f to
28d69df
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a dynamic internationalization (i18n) build process for the documentation, adding German translations and a switcher for multiple languages. It introduces scripts to compile .po catalogs to .mo files before the Sphinx HTML build, both locally and on Read the Docs, falling back to sphinx-intl if babel is not installed. Feedback on the changes highlights a critical bug in conf.py where config.tags.add is called instead of app.tags.add, which would crash the build. Additionally, it is recommended to move the .mo compilation logic from the module-level import of conf.py into the setup(app) function to avoid executing subprocesses during simple imports. Other suggestions include fixing a bug in resolve_sphinx_language where an explicit "en" locale is not correctly resolved to None, and checking babel availability at the module level in build_i18n.py to prevent misleading error logs during compilation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive internationalization (i18n) support for the documentation, adding a catalog compilation script, a locale resolver, and German translation files. Feedback on the changes suggests three important fixes: restoring json_url to an absolute URL in conf.py to avoid breaking the version switcher on nested pages, normalizing the explicit locale argument in i18n_locales.py to prevent directory resolution failures, and adding a directory existence check in _build_mo_with_sphinx_intl to ensure robust compilation across all locales.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Please review this pr @qinxuye .Thanks！ |
addd9ce to
e851048
Compare
Add German locale catalogs and i18n build infrastructure for Read the Docs documentation. Co-authored-by: Cursor <cursoragent@cursor.com>
e851048 to
f6f0b5a
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces German translation files (.po) for various documentation pages and updates the PO scanner script to recognize German translation patterns. The review feedback highlights several translation and formatting issues across the newly added files. Key corrections include fixing the Plural-Forms header to match German grammar, correcting inaccurate or unnatural translations of headings (such as 'Prerequisites', 'Logging in Xinference', and 'Start Local Server'), addressing singular/plural mismatches, and removing unnecessary leading or trailing spaces inside markdown bold and inline code markers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Correct Plural-Forms headers, heading translations, singular/plural mismatches, and markdown formatting in de locale files.
3 participants
Summary
Preview
Test plan
Made with Cursor