Skip to content

fix(monero): quarantine broadcastTx and map fee priorities - #1766

Open
Thorian1te wants to merge 1 commit into
fix/monero-client-hardeningfrom
fix/monero-transfer-hygiene
Open

fix(monero): quarantine broadcastTx and map fee priorities#1766
Thorian1te wants to merge 1 commit into
fix/monero-client-hardeningfrom
fix/monero-transfer-hygiene

Conversation

@Thorian1te

Copy link
Copy Markdown
Collaborator

Summary

PR2 of the Monero wallet-rpc hardening stack (stacks on #1765):

  • broadcastTx now throws — the old path returned a non-canonical keccak txid and encouraged the experimental builder; use transfer()
  • Builder API — remove BuiltTransaction / related types from the package root export; docs mark tx/builder as R&D-only
  • feeOption → wallet-rpc priority — Average=2, Fast=3, Fastest=4 (added optional feeOption on Monero TxParams)
  • Amount precision — clearer error when amount exceeds Number.MAX_SAFE_INTEGER (JSON-RPC Number limit)

Test plan

  • yarn workspace @xchainjs/xchain-monero test (131 passed)
  • yarn build --filter=@xchainjs/xchain-monero

Stack

  1. fix(monero): harden address, purge, and unlocked balance #1765 — address / purge / unlocked balance
  2. This PR — transfer / broadcast hygiene
  3. (next) multi-index wallet-rpc
  4. (next) stagenet spend e2e

Make broadcastTx throw (use wallet-rpc transfer), stop exporting
experimental RingCT builder types from the package root, map FeeOption
to wallet-rpc priority, and clarify JSON amount precision errors.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 544c4dca-45aa-49e0-9ac7-713cd9e515bc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant