fix(monero): quarantine broadcastTx and map fee priorities - #1766
Open
Thorian1te wants to merge 1 commit into
Open
fix(monero): quarantine broadcastTx and map fee priorities#1766Thorian1te wants to merge 1 commit into
Thorian1te wants to merge 1 commit into
Conversation
Make broadcastTx throw (use wallet-rpc transfer), stop exporting experimental RingCT builder types from the package root, map FeeOption to wallet-rpc priority, and clarify JSON amount precision errors.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR2 of the Monero wallet-rpc hardening stack (stacks on #1765):
broadcastTxnow throws — the old path returned a non-canonical keccak txid and encouraged the experimental builder; usetransfer()BuiltTransaction/ related types from the package root export; docs marktx/builderas R&D-onlyfeeOption→ wallet-rpc priority — Average=2, Fast=3, Fastest=4 (added optionalfeeOptionon MoneroTxParams)Number.MAX_SAFE_INTEGER(JSON-RPC Number limit)Test plan
yarn workspace @xchainjs/xchain-monero test(131 passed)yarn build --filter=@xchainjs/xchain-moneroStack