Skip to content

fix(monero): resolve balance/history across HD wallet indices - #1767

Open
Thorian1te wants to merge 1 commit into
fix/monero-transfer-hygienefrom
fix/monero-multi-index-rpc
Open

fix(monero): resolve balance/history across HD wallet indices#1767
Thorian1te wants to merge 1 commit into
fix/monero-transfer-hygienefrom
fix/monero-multi-index-rpc

Conversation

@Thorian1te

Copy link
Copy Markdown
Collaborator

Summary

PR3 of the Monero wallet-rpc hardening stack (stacks on #1766#1765):

  • Resolve getBalance / getTransactions / getWalletBalanceDetail addresses to HD walletIndex 0–20
  • Each index opens its own wallet-rpc file (xchain-${addressPrefix}) — already how prepareWalletRpc worked for transfer({ walletIndex })
  • LWS + daemon-scan fallbacks use the matching index’s view/spend keys
  • Daemon scan cache is keyed by walletIndex so index 0 and 1 do not mix outputs

Test plan

  • Unit tests including non-zero index wallet-rpc open (132 passed)
  • yarn build --filter=@xchainjs/xchain-monero

Stack

  1. fix(monero): harden address, purge, and unlocked balance #1765 — address / purge / unlocked
  2. fix(monero): quarantine broadcastTx and map fee priorities #1766 — broadcastTx / fee priority
  3. This PR — multi-index rpc parity
  4. (next) stagenet spend e2e

Map getBalance/getTransactions addresses to walletIndex 0–20, open the
matching wallet-rpc file, and use the correct view/spend keys for LWS
and daemon-scan fallbacks (scan cache keyed by index).
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d15a8775-724a-4806-baf1-b3847126f987

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant