Skip to content

Fix #27869: Add missing alt attributes on images across features/ for accessibility #10509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dhruvirana08 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix #27869: Add missing alt attributes on images across features/ for accessibility #10509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94eea0c
fix: add missing alt attribute to files in admin.flow-builder-core.v1
Dhruvirana08 Jul 2, 2026
2cbd799
fix: add missing alt attribute to application-template-card.tsx in ad…
Dhruvirana08 Jul 2, 2026
2949689
fix: add missing alt attribute to feature-preview-modal.tsx in admin.…
Dhruvirana08 Jul 2, 2026
640a8e8
fix: add missing alt attribute to button-adapter.tsx in admin.flow-bu…
Dhruvirana08 Jul 2, 2026
5cce89e
fix: add missing alt attribute to sign-in-box-node.tsx in admin.login…
Dhruvirana08 Jul 2, 2026
ba8f246
fix: add missing alt attribute to push-provider-card.tsx in admin.pus…
Dhruvirana08 Jul 2, 2026
b57e638
Add changeset 🦋
Dhruvirana08 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/three-moles-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@wso2is/console": patch
"@wso2is/admin.application-templates.v1": patch
"@wso2is/admin.core.v1": patch
"@wso2is/admin.flow-builder-core.v1": patch
"@wso2is/admin.login-flow-builder.v1": patch
"@wso2is/admin.push-providers.v1": patch
---

Add missing alt attributes on images across multiple components for accessibility.
1 change: 1 addition & 0 deletions features/admin.application-templates.v1/components/application-template-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ const ApplicationTemplateCard: FunctionComponent<ApplicationTemplateCardPropsInt
ResourceTypes.APPLICATIONS
)
}
alt=""

@pavinduLakshan pavinduLakshan Jul 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add something meaningful here?

loading="lazy"
/>
</div>
Expand Down
1 change: 1 addition & 0 deletions features/admin.core.v1/components/modals/feature-preview-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ const FeaturePreviewModal: FunctionComponent<FeaturePreviewModalPropsInterface>
{ selected?.image && (
<img
src={ selected.image }
alt={ `${selected?.name} preview` }
style={ { marginBottom: "20px", marginTop: "20px", width: "100%" } }
/>
) }
Expand Down
4 changes: 2 additions & 2 deletions ...ures/admin.flow-builder-core.v1/components/resources/elements/adapters/button-adapter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ const ButtonAdapter: FunctionComponent<ButtonAdapterPropsInterface> = ({
<Button
sx={ resource?.config.styles }
startIcon={ resource?.config?.image
? <img src={ loadStaticResource(resource?.config?.image) } height={ 20 } />
: image && <img src={ loadStaticResource(image) } height={ 20 } />
? <img src={ loadStaticResource(resource?.config?.image) } alt="" height={ 20 } />
: image && <img src={ loadStaticResource(image) } alt="" height={ 20 } />
}
{ ...config }
>
Expand Down
2 changes: 1 addition & 1 deletion ...uilder-core.v1/components/resources/steps/execution/execution-factory/apple-execution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const AppleExecution = ({

return (
<Box display="flex" gap={ 1 } data-componentid={ componentId } className="flow-builder-execution apple">
<img src={ loadStaticResource("assets/images/icons/apple.svg") } height="20" />
<img src={ loadStaticResource("assets/images/icons/apple.svg") } alt="" height="20" />
<Typography variant="body1">{ t("flows:core.executions.names.apple") }</Typography>
</Box>
);
Expand Down
2 changes: 1 addition & 1 deletion ...der-core.v1/components/resources/steps/execution/execution-factory/facebook-execution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const FacebookExecution = ({

return (
<Box display="flex" gap={ 1 } data-componentid={ componentId }>
<img src={ loadStaticResource("assets/images/icons/facebook.svg") } height="20" />
<img src={ loadStaticResource("assets/images/icons/facebook.svg") } alt="" height="20" />
<Typography variant="body1">{ t("flows:core.executions.names.facebook") }</Typography>
</Box>
);
Expand Down
2 changes: 1 addition & 1 deletion ...ilder-core.v1/components/resources/steps/execution/execution-factory/github-execution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const GithubExecution = ({

return (
<Box display="flex" gap={ 1 } data-componentid={ componentId } className="flow-builder-execution github">
<img src={ loadStaticResource("assets/images/icons/github.svg") } height="20" />
<img src={ loadStaticResource("assets/images/icons/github.svg") } alt="" height="20" />
<Typography variant="body1">{ t("flows:core.executions.names.github") }</Typography>
</Box>
);
Expand Down
2 changes: 1 addition & 1 deletion ...ilder-core.v1/components/resources/steps/execution/execution-factory/google-execution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const GoogleExecution = ({

return (
<Box display="flex" gap={ 1 } data-componentid={ componentId }>
<img src={ loadStaticResource("assets/images/icons/google.svg") } height="20" />
<img src={ loadStaticResource("assets/images/icons/google.svg") } alt="" height="20" />
<Typography variant="body1">{ t("flows:core.executions.names.google") }</Typography>
</Box>
);
Expand Down
6 changes: 3 additions & 3 deletions ...min.flow-builder-core.v1/components/resources/steps/execution/execution-factory/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const ExecutionFactory: FC<ExecutionFactoryPropsInterface> = ({
if ((resource.data?.action as any)?.executor?.name === ExecutionTypes.PasskeyEnrollment) {
return (
<Box display="flex" gap={ 1 } data-componentid={ componentId }>
<img src="https://www.svgrepo.com/show/246819/fingerprint.svg" height="20" />
<img src="https://www.svgrepo.com/show/246819/fingerprint.svg" alt="" height="20" />
<Typography variant="body1">{ t("flows:core.executions.names.passkeyEnrollment") }</Typography>
</Box>
);
Expand All @@ -96,7 +96,7 @@ const ExecutionFactory: FC<ExecutionFactoryPropsInterface> = ({
data-componentid={ componentId }
className="flow-builder-execution magic-link"
>
<img src="https://www.svgrepo.com/show/524687/link.svg" height="20"/>
<img src="https://www.svgrepo.com/show/524687/link.svg" alt="" height="20"/>
<Typography variant="body1">{ t("flows:core.executions.names.magicLink") }</Typography>
</Box>
);
Expand All @@ -116,7 +116,7 @@ const ExecutionFactory: FC<ExecutionFactoryPropsInterface> = ({
data-componentid={ componentId }
className="flow-builder-execution confirmation-code"
>
<img src="https://www.svgrepo.com/show/468264/check-mark-square-2.svg" height="20"/>
<img src="https://www.svgrepo.com/show/468264/check-mark-square-2.svg" alt="" height="20"/>
<Typography variant="body1">{ t("flows:core.executions.names.confirmationCode") }</Typography>
</Box>
);
Expand Down
2 changes: 1 addition & 1 deletion ...er-core.v1/components/resources/steps/execution/execution-factory/microsoft-execution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const MicrosoftExecution = ({

return (
<Box display="flex" gap={ 1 } data-componentid={ componentId }>
<img src={ loadStaticResource("assets/images/icons/microsoft.svg") } height="20" />
<img src={ loadStaticResource("assets/images/icons/microsoft.svg") } alt="" height="20" />
<Typography variant="body1">{ t("flows:core.executions.names.microsoft") }</Typography>
</Box>
);
Expand Down
2 changes: 1 addition & 1 deletion features/admin.login-flow-builder.v1/components/nodes/sign-in-box-node/sign-in-box-node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ const SignInBoxNode: FunctionComponent<SignInBoxNodePropsInterface> = (

const signInButton: ReactElement = (
<Button
startIcon={ <img className="oxygen-sign-in-option-image" src={ authenticator.image } /> }
startIcon={ <img className="oxygen-sign-in-option-image" src={ authenticator.image } alt="" /> }
variant="contained"
className="oxygen-sign-in-option"
type="button"
Expand Down
1 change: 1 addition & 0 deletions features/admin.push-providers.v1/components/push-provider-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ const PushProviderCard: FunctionComponent<PushProviderCardPropsInterface> = ({
ResourceTypes.NOTIFICATION_PROVIDERS
)
}
alt=""
loading="lazy"
/>
</div>
Expand Down