Skip to content

Fix #27869: Add missing alt attributes on images across features/ for accessibility#10509

Open
Dhruvirana08 wants to merge 7 commits into
wso2:masterfrom
Dhruvirana08:fix-issue-27869
Open

Fix #27869: Add missing alt attributes on images across features/ for accessibility#10509
Dhruvirana08 wants to merge 7 commits into
wso2:masterfrom
Dhruvirana08:fix-issue-27869

Conversation

@Dhruvirana08

@Dhruvirana08 Dhruvirana08 commented Jul 6, 2026

Copy link
Copy Markdown

Purpose

There were 14 <img> elements across the features/ directory missing the alt attribute, which impacts screen reader users and is required for WCAG 2.1 AA compliance (per this repo's accessibility guidelines on supporting screen readers with semantic HTML). This PR adds alt attributes across the affected files:

  • alt="" for decorative icons that sit alongside a visible text label already describing the image (e.g. social login icons paired with their provider name) — this explicitly signals to assistive technology to skip the image, rather than leaving it to fall back to inconsistent or unhelpful behavior across different screen readers when alt is omitted entirely.
  • A descriptive alt value for standalone images that convey information on their own, with no adjacent text label (e.g. template/feature preview images), using the relevant item name where available.

This change has no visible UI impact, so no screenshots are included — verification was done via source-level review, and confirming no build/lint regressions were introduced.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Developer Checklist (Mandatory)

  • [Behavioural Change] Does this change introduce a behavioral change to the product?
  • ↳ Approved by team lead
  • ↳ Label impact/behavioral-change added
  • [Migration Impact] Does this change have a migration impact?
  • ↳ Migration label added (e.g., 7.2.0-migration)
  • ↳ Migration issues created and linked
  • [New Configuration] Does this change introduce a new configuration?
  • ↳ Label config added
  • ↳ Configuration is properly documented

@CLAassistant

CLAassistant commented Jul 6, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds alt attributes to <img> elements across multiple admin feature components for accessibility, including application template cards, feature preview modal, flow-builder execution icons, button adapters, login flow builder sign-in nodes, and push provider cards, plus an accompanying changeset entry.

Changes

Image Accessibility Attribute Additions

Layer / File(s) Summary
Changeset entry
.changeset/three-moles-jump.md
Records patch version bumps for multiple @wso2is/* packages and a release note about adding missing alt attributes for accessibility.
Card and modal images
features/admin.application-templates.v1/components/application-template-card.tsx, features/admin.core.v1/components/modals/feature-preview-modal.tsx, features/admin.push-providers.v1/components/push-provider-card.tsx
Adds alt attributes to header, preview, and template card images, with the feature preview modal interpolating the selected feature's name into the alt text.
Flow-builder execution and adapter icons
features/admin.flow-builder-core.v1/components/resources/elements/adapters/button-adapter.tsx, features/admin.flow-builder-core.v1/components/resources/steps/execution/execution-factory/*
Adds empty alt="" attributes to icon images for button adapters and execution steps (Apple, Facebook, GitHub, Google, Microsoft, Passkey Enrollment, Magic Link, Confirmation Code) while preserving existing src and height props.
Login flow builder sign-in node
features/admin.login-flow-builder.v1/components/nodes/sign-in-box-node/sign-in-box-node.tsx
Adds an empty alt attribute to the startIcon image used for dynamic sign-in option buttons.

Suggested reviewers: DilshanSenarath

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Changeset Required ✅ Passed PR diff includes .changeset/three-moles-jump.md, a non-README changeset listing the affected @wso2is packages.
Title check ✅ Passed The title clearly summarizes the main change: adding missing alt attributes for accessibility across features/.
Description check ✅ Passed The description follows the template with Purpose, Related Issues/PRs, checklist, security checks, and developer checklist sections.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from DilshanSenarath July 6, 2026 05:06
ResourceTypes.APPLICATIONS
)
}
alt=""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add something meaningful here?

@pavinduLakshan pavinduLakshan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add suitable values for the alt attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[React Doctor] alt-text: Missing alt attribute (14 occurrences)

3 participants