Fix #27869: Add missing alt attributes on images across features/ for accessibility#10509
Open
Dhruvirana08 wants to merge 7 commits into
Open
Fix #27869: Add missing alt attributes on images across features/ for accessibility#10509Dhruvirana08 wants to merge 7 commits into
Dhruvirana08 wants to merge 7 commits into
Conversation
…min.application-templates.v1
Contributor
📝 WalkthroughWalkthroughThis PR adds ChangesImage Accessibility Attribute Additions
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ResourceTypes.APPLICATIONS | ||
| ) | ||
| } | ||
| alt="" |
Member
There was a problem hiding this comment.
shall we add something meaningful here?
pavinduLakshan
left a comment
Member
There was a problem hiding this comment.
Please add suitable values for the alt attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
There were 14
<img>elements across thefeatures/directory missing thealtattribute, which impacts screen reader users and is required for WCAG 2.1 AA compliance (per this repo's accessibility guidelines on supporting screen readers with semantic HTML). This PR addsaltattributes across the affected files:alt=""for decorative icons that sit alongside a visible text label already describing the image (e.g. social login icons paired with their provider name) — this explicitly signals to assistive technology to skip the image, rather than leaving it to fall back to inconsistent or unhelpful behavior across different screen readers when alt is omitted entirely.altvalue for standalone images that convey information on their own, with no adjacent text label (e.g. template/feature preview images), using the relevant item name where available.This change has no visible UI impact, so no screenshots are included — verification was done via source-level review, and confirming no build/lint regressions were introduced.
Related Issues
altattribute (14 occurrences) product-is#27869Related PRs
Checklist
Security checks
Developer Checklist (Mandatory)
impact/behavioral-changeadded7.2.0-migration)configadded