fix(e2): temporal resolution applies to quoted/attributed claim forms (#158 follow-up) - #181
Merged
Conversation
fazpu
enabled auto-merge (squash)
July 29, 2026 23:14
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Under 07i, claims surviving in direct-quote form systematically lack valid-time: "Caroline said: I went to a LGBTQ support group yesterday…" carried no stamp (anchor 2023-05-08 in header, expected 2023-05-07) while paraphrase-form claims stamp correctly (34/416 dated, honest precisions). The model treats relative dates inside quotations as exempt — and the token-tolerant gate (#180) means far more attributed/quoted claims now survive, so the gap became load-bearing: the #158 gold acceptance claim flip-flopped between extractor generations depending on which claim form won.
Prompt-only fix: the temporal section now states resolution is required regardless of claim form (quoted/attributed speech never exempt; quoted text stays verbatim, resolution only in
valid_*fields), with a worked example in exactly the failing form.E2_EXTRACTOR_VERSION07i→07j (temporal-anchor-2). Test pins the new language and example.Reviews
Grok-4.5: APPROVE — verified diff is prompt/version/test/docs-only, example arithmetic correct, no gate regression, tests non-vacuous. Non-blocking note: impact re-measurement happens on the next ingest (the VM acceptance gate checks exactly this claim's stamp).
Claude (final review): verified prompt section, version convention, ran the suite (12 passed).
I have read and agree to the RememberStack Contributor License Agreement v1.0.