Aptos Watcher Tests + event type check#4838
Conversation
|
I ran the reobservation flow on the production watcher for a while. It was picking up all of the events that were identifiable on Wormholesan. |
|
This broke the tilt CI. I'll figure out why and fix that. |
djb15
left a comment
There was a problem hiding this comment.
Minor comment on the code comment, but otherwise this looks good
pleasew8t
left a comment
There was a problem hiding this comment.
First pass looks good. Left a few suggestions.
djb15
left a comment
There was a problem hiding this comment.
Happy from my side. Will review any changes requested by the other reviewers
|
@pleasew8t I made some changes based on your feedback. Feel free to review it again. |
djb15
left a comment
There was a problem hiding this comment.
Changes in the latest commit look good
bemic
left a comment
There was a problem hiding this comment.
I went over the code and my one comment would be regarding the 0x/0X, but it is already covered in Jason's comment.
The second comment, apparently Aptos addresses with stripped zeros can be used. Example from Aptos docs is 0x1. However I don't really know how rare it is.
|
@bemic I saw this too but didn't decide to dig further. It appears that the The type is returned as |
The PR does the following: