node: Add watcher interface and implement in Aptos#4780
Draft
johnsaigle wants to merge 8 commits into
Draft
Conversation
johnsaigle
force-pushed
the
feat-valid-obs-aptos
branch
2 times, most recently
from
145dad3 to
7312c3f
Compare
johnsaigle
requested review from
SEJeff,
bemic,
djb15,
evan-gray,
kcsongor,
mdulin2,
panoel and
pleasew8t
as code owners
bemic
previously approved these changes
May 6, 2026
bemic
left a comment
bemic
left a comment
Contributor
There was a problem hiding this comment.
I left two defense-check ideas to consider, otherwise I think its a good change
johnsaigle
force-pushed
the
feat-valid-obs-aptos
branch
from
ca0459b to
b970e64
Compare
johnsaigle
force-pushed
the
feat-valid-obs-aptos
branch
from
b970e64 to
afadce9
Compare
Contributor
Author
|
Converting to draft mode:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4761