Skip to content

CI: run the Playwright e2e suite - #46

Merged
wilsonhj merged 3 commits into
mainfrom
claude/mystifying-cannon-51628f
Oct 31, 2026
Merged

wilsonhj merged 3 commits into
mainfrom
claude/mystifying-cannon-51628f

Conversation

@wilsonhj

Copy link
Copy Markdown
Owner

Adds an `e2e` job to `.github/workflows/ci.yml` that runs `pnpm test:e2e` (slice G, `.github/**`).

  • Own job with its own 15-minute timeout, in parallel with `check`. The config starts `next dev` itself, so it needs no `pnpm build`.
  • Fully offline: `playwright.config.ts` points the app at `tests/mock-comfy`; `COMFY_API_KEY` is a dummy.
  • Installs the browser with `pnpm exec playwright install --with-deps chromium` (forbidden locally by the config, fine on a runner).
  • `CI=true` turns on the config's CI behaviour: `retries: 1`, the HTML reporter, `forbidOnly`, and no `reuseExistingServer`.
  • On failure, uploads `test-results/` (traces, screenshots) and `playwright-report/` as the `e2e-results` artifact.

Why: a Listing e2e test from #44 left a run submitting jobs after it ended, which broke `motion.spec.ts` in every full local run while CI stayed green (fix in #45).

Note: with `retries: 1`, a test that fails once and passes on retry is reported as flaky and does not fail the job.

🤖 Generated with Claude Code

wilsonhj and others added 3 commits October 30, 2026 16:13
Its own job, so a cross-spec leak like the one PR #45 fixes fails a PR
instead of only full local runs. Uploads test-results/ and the HTML
report when it fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wilsonhj
wilsonhj merged commit 3e84d21 into main Oct 31, 2026
2 checks passed
wilsonhj added a commit that referenced this pull request Oct 31, 2026
* CI: run the Playwright e2e suite against the mock Comfy API

Its own job, so a cross-spec leak like the one PR #45 fixes fails a PR
instead of only full local runs. Uploads test-results/ and the HTML
report when it fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* TEMP: break a smoke assertion to prove CI e2e fails (will be reverted)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Revert the temporary broken smoke assertion

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
wilsonhj added a commit that referenced this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant