Repository navigation
Pull request: Define the merge box section row's measurements once - #88
Merged
Merged
Conversation
The scheduled-merge notice is styled as a merge box section in the page stylesheet and repeated the section row's numbers by hand: 64px height, 16px padding, a 32px icon and the divider colour. The merge box now declares them as custom properties where its rows are styled, and both the rows and the notice read them. No visual change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #87 (base is its branch).
What
A merge box section row is styled in
styles/components/issues/pull_review.ts. The scheduled-merge notice (#83) is styled as one more row instyles/pages/pull-request.css; because Forgejo's notice has different markup, it could not share the rule and repeated its numbers..merge.boxnow declares the row's measurements as custom properties:--merge-section-height--merge-section-padding--merge-section-icon--merge-section-dividerThe section rows, the status icon fragment and the notice all read them, so a change to the row applies to both.
Verification
Re-created the scheduled-merge state in the preview (removed afterwards). The notice measures as before: full width, 1–66px tall in the bar, 32px icon at 16px/16px, merge button at 82–114px, instructions link at 122–140px; the other rows are still 64–65px with 16px padding.
bun vitest(403 passed),bun checkand Prettier pass.🤖 Generated with Claude Code