Repository navigation
Editor: Move the markdown editor styles into a common component - #89
Merged
Merged
Conversation
The editor rules lived in the issue styles of the theme files although they also serve the release form, and counted against the theme size limit. They move, unchanged, to components/common/editor/editor.css with the other common components. The largest theme file drops from 208.0 KB to 205.4 KB. No visual change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #88 (base is its branch).
What
styles/components/issues/editor.tsheld GitHub's comment editor for five hosts (comment form, new issue page, review panel, diff comment form, release form). It was part of the theme files, under the issue styles.It moves to
components/common/editor/editor.css, linked fromcomponent_assets.tmpllike the other common components. The rules are unchanged; the theme variable references become the CSS variables they compile to (--border-radius,--color-body,--color-box-header,--color-light-border,--color-text-light-1,--color-text,--github-fgColor-accent). The host list is one flat:is().Verification
The 21-page before/after comparison: every page with a visible editor (issue, new issue, pull request, new release) is identical. The review panel and the diff comment form, which open on demand, were measured after the move: 640px panel, editor inset 17px, 38px toolbar on the header background, 1px editor border, 32px borderless attachment line.
bun vitest(403 passed),bun checkand Prettier pass.🤖 Generated with Claude Code