Repository navigation
Menus: Put the merge method and Update branch menus into one menu component - #87
Merged
Merged
Conversation
…ponent Both menus restyle Forgejo's native dropdown as GitHub's menu of 32px rows without dividers, but one lived in the pull request theme styles and the other in the pull request page stylesheet, written separately. components/common/menu/menu.css now holds both: the shared row rules once, then what differs between an action menu and a single-choice menu with its check mark. Another menu is styled by adding it to the list. No visual change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #86 (base is its branch).
What
Two menus on the pull request page restyle Forgejo's native dropdown as GitHub's action menu (8px padding, 32px rows, 6px radius, no divider lines):
styles/components/issues/pull_review.ts;styles/pages/pull-request.css.They were written separately.
components/common/menu/menu.css(new, linked fromcomponent_assets.tmpl) now holds both: the rules they share are written once for a list of menus, followed by what differs between the two kinds — an action menu, and a single-choice menu whose current choice carries a check mark. Styling another native menu means adding its selector to the list.Left alone: the tooltip-style "…" menus (upstream's
tippy.ts) andcomponents/common/dropdown, which is GitHub's select panel with dividers, a different pattern.Verification
Both menus measure the same as before the move: merge method menu 280px wide, 8px padding, 32px rows with
6px 8pxpadding and no borders; "Update branch" menu at 755–974px by 430–510px after a real click, rows indented 32px with the check mark. The 21-page before/after comparison is unchanged from #86.bun vitest(403 passed),bun checkand Prettier pass.🤖 Generated with Claude Code