Repository navigation
Lists: Use the shared list heading on every list page - #86
Merged
Merged
Conversation
The repository issue and pull request lists, the dashboard lists and the notifications page each carried their own copy of the heading rules that the theme-list-heading component already provides. They now use the component; only the 16px gap below the heading stays with the pages. The right-aligned count in a sidebar entry moves from the dashboard stylesheet into the sidebar component. No visual change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #85 (base is its branch).
What
components/common/list-heading(a heading row with a title and an optional action; 20px / 600 title) was only used by the organization repository list. Three other places re-declared the same rules:styles/components/issues/issue_overview.ts:.list-header-issues,.issue-list-titleand itsh1, used by the repository issue and pull request lists and, through shared classes, the dashboard issue, pull request and milestone lists.styles/pages/dashboard-lists.css:.github-notifications-header,.github-notifications-titleand itsh1.The four templates now carry
theme-list-heading/theme-list-title, and the copies are deleted. Each page keeps one line for its 16px gap below the heading (the component's default is 8px).The sidebar counter rules (count at the right edge, label truncating before it) move from
dashboard-lists.csstocomponents/common/sidebar/sidebar.css, so any sidebar can use them.Verification
Before/after comparison of every element's position, size, colours, font and borders on 21 preview pages: all list pages (repository issues and pull requests, dashboard issues, pull requests, milestones, notifications, organization) are identical; the only differences are the run-to-run noise described in #85.
bun vitest(403 passed),bun checkand Prettier pass.🤖 Generated with Claude Code