Fix routine table log icons wrapping to new line#1274
Open
faizan7800 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1264
The comparison icons (up/down/flag) in the "Logged" row of the routine
table view (/routine//table) were wrapping onto their own line below
the logged value instead of staying next to it, since the value and icon
were rendered inside a plain with no layout control.
Fixed by wrapping the value + icon in a Box with display: inline-flex,
alignItems: center, and a small gap, applied consistently across all four
logged columns (reps, weight, rest time, RiR).