fix(bundle): align the web debug toolbar item with the Symfony core styles - #671
Merged
Conversation
…tyles The item label used `sf-toolbar-status`, which renders it on a grey badge instead of the plain value styling of the core items. It now uses `sf-toolbar-value`. The icon was a base64 PNG export of the jwt.io logo, on an opaque white background and with fixed colours, which looked out of place next to the monochrome core icons. It is replaced by the official jwt.io SVG, normalised to the 24x24 grid used by the WebProfilerBundle icons and painted with `currentColor`, so the mark follows the toolbar foreground in both the light and the dark theme -- including the two branches that jwt.io itself renders white or black depending on the background. Fixes #663
Spomky
force-pushed
the
fix/profiler-toolbar-styles
branch
from
August 6, 2026 21:14
8406888 to
b62ea89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #663.
Label —
JWTwas wrapped insf-toolbar-status, which renders it on a grey badge. Core usessf-toolbar-valuefor a toolbar item value, so the label now sits on the toolbar background like the other items.Icon — the item embedded a base64 PNG export of the jwt.io logo: fixed colours, on an opaque white background, which is what made it stand out next to the monochrome core icons.
It is replaced by the official SVG from jwt.io (
https://jwt.io/img/pic_logo.svg), extracted toResources/views/data_collector/icon.svgand pulled in withsource(), the same mechanism the WebProfilerBundle uses for@WebProfiler/Icon/*.svg. The paths are normalised to the 24×24 grid of the core icons (2 units of padding,role="img",<title>) and painted withcurrentColorinstead of the brand palette, so the mark inherits the toolbar foreground colour and works in both the light and the dark theme — including the two branches that jwt.io itself renders white or black depending on the background.The
menublock of the profiler panel uses the same file.The
sf-toolbar-statusspans of the dropdown info pieces are left alone — the CSS classes do the job there.Rendering only; no behavioural change and no public API touched.