Skip to content

Match the profiler toolbar icon to the Symfony core icons - #464

Merged
Spomky merged 1 commit into
1.5.xfrom
fix/profiler-toolbar-icon
Aug 16, 2026
Merged

Match the profiler toolbar icon to the Symfony core icons#464
Spomky merged 1 commit into
1.5.xfrom
fix/profiler-toolbar-icon

Conversation

@Spomky

@Spomky Spomky commented Aug 16, 2026

Copy link
Copy Markdown
Member

Same fix as web-token/jwt-framework#671, applied here: the toolbar icon did not match the styling of the Symfony core toolbar items.

The label was already using sf-toolbar-value, so only the icon was affected.

Before

templates/Collector/pwa.svg was an SVG Repo export of the PWA logo:

  • an 800x800 drawing on a 0 -159.5 512 512 viewBox, so it did not sit on the same grid as the WebProfilerBundle icons;
  • painted with the fixed brand colours #3D3D3D and #5A0FC8, so it could not inherit the toolbar foreground colour — it stayed dark grey and purple whatever the theme, and was close to invisible on the dark toolbar;
  • carrying an XML prolog, which source() inlined as-is into the HTML page.

After

The drawing is normalised to the 24x24 grid used by the WebProfilerBundle icons, vertically centred, and painted with currentColor so it follows the toolbar foreground in both the light and the dark themes. The prolog is gone.

Rendering-only change: no behaviour and no public API is touched, and the two source() call sites in templates/Collector/template.html.twig are unchanged.

The PWA icon shipped for the web debug toolbar was an SVG Repo export of
the PWA logo: an 800x800 drawing on a `0 -159.5 512 512` viewBox, painted
with the fixed brand colours `#3D3D3D` and `#5A0FC8`.

Because of the fixed colours the icon could not inherit the toolbar
foreground colour, so it stayed dark grey and purple whatever the theme,
and turned nearly invisible on the dark toolbar. The oversized viewBox
also made it sit differently from the core items, and the XML prolog was
inlined as-is into the HTML page by `source()`.

The drawing is now normalised to the 24x24 grid used by the
WebProfilerBundle icons, vertically centred, and painted with
`currentColor` so it follows the toolbar foreground in both the light and
the dark themes.
@Spomky Spomky self-assigned this Aug 16, 2026
@Spomky Spomky added this to the 1.5.12 milestone Aug 16, 2026
@Spomky Spomky added the bug Something isn't working label Aug 16, 2026
@Spomky
Spomky merged commit 1ac5c19 into 1.5.x Aug 16, 2026
17 checks passed
@Spomky
Spomky deleted the fix/profiler-toolbar-icon branch August 16, 2026 18:20
Spomky added a commit that referenced this pull request Aug 16, 2026
* 1.5.x:
  Match the profiler toolbar icon to the Symfony core icons (#464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant