Skip to content

Bump napi: imports-lane parity fixes (ECO-416) - #6825

Closed
Arshia001 wants to merge 1 commit into
eco-415-guest-finalizersfrom
eco-416-imports-parity
Closed

Bump napi: imports-lane parity fixes (ECO-416)#6825
Arshia001 wants to merge 1 commit into
eco-415-guest-finalizersfrom
eco-416-imports-parity

Conversation

@Arshia001

Copy link
Copy Markdown
Member

Submodule bump only — pulls wasmerio/napi#46 into the wasmer CLI's N-API runtime:
CreateBufferObject-via-prototype, napi_create_string_utf8/latin1 NUL fix, and structuredClone empty-transfer-list fix.

Verified via the edgejs v8-wasix node suite (1662 pass / 0 failures). Stacked on the ECO-415 branch; not independently mergeable yet.

🤖 Generated with Claude Code

@Arshia001
Arshia001 requested a review from syrusakbary as a code owner July 28, 2026 14:31
@Arshia001
Arshia001 force-pushed the eco-416-imports-parity branch from 16e4e54 to 612709f Compare July 28, 2026 14:31
Copilot AI review requested due to automatic review settings July 28, 2026 14:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the lib/napi git submodule pointer so the wasmer CLI’s N-API runtime picks up the fixes from wasmerio/napi#46 (imports-lane parity fixes called out in ECO-416).

Changes:

  • Bump lib/napi submodule from d8940cae… to 8224dc35… (head of wasmerio/napi#46).
  • Pull in upstream fixes mentioned in the PR description (buffers via prototype, string NUL handling, structuredClone empty transfer list handling).

@Arshia001
Arshia001 force-pushed the eco-416-imports-parity branch from 612709f to ba8f787 Compare July 28, 2026 14:54
@Arshia001
Arshia001 force-pushed the eco-416-imports-parity branch from ba8f787 to e4e6008 Compare July 28, 2026 16:10
@Arshia001

Copy link
Copy Markdown
Member Author

Superseded by #6877, which replaces this whole stack with a single PR.

Nine of the ten PRs here were pure lib/napi submodule bumps; #6877's napi pin is a descendant of every one of them, so it subsumes them all. #6822 was the only one carrying code — its SharedMemory::vm_shared_memory() accessor is reworked in #6877 into SharedMemory::grow/data_ptr/style, which keep the VM types encapsulated, avoid the unwrap_sys_ref() panic on non-sys backends, and fix the cargo doc --no-default-features --features v8 failure Copilot flagged. Its Cargo.lock entries are carried over too.

Not abandoned work — same changes, one reviewable PR.

@Arshia001 Arshia001 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants