Skip to content

Bump napi: re-raise guest WASI process exits (ECO-416) - #6829

Open
Arshia001 wants to merge 1 commit into
eco-416-imports-parityfrom
eco-416-tls-handshake
Open

Bump napi: re-raise guest WASI process exits (ECO-416)#6829
Arshia001 wants to merge 1 commit into
eco-416-imports-parityfrom
eco-416-tls-handshake

Conversation

@Arshia001

Copy link
Copy Markdown
Member

Bumps the lib/napi submodule to pull wasmerio/napi#47 (317fac4).

The N-API callback trampoline now re-raises a guest WasiError::Exit (Node's fatal-exception std::_Exit on the main thread) through the N-API import layers instead of swallowing it. A guest that proc_exits from inside a host→guest callback now tears down only its own instance cleanly, instead of leaving the host event loop spinning forever. Fixes test-tls-handshake-exception on the V8-imports lane (the last V8-only parity gap in the parallel/ surface).

Cargo.lock is unchanged (making wasmer-wasix non-optional in the napi crate changes only a feature edge; the CLI already links wasix). Stacked on #6825.

🤖 Generated with Claude Code

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the lib/napi git submodule to pick up ECO-416 behavior changes so that guest proc_exit/WasiError::Exit raised from inside a host→guest callback is re-propagated through the N-API import layers (instead of being swallowed), preventing hangs in the host event loop.

Changes:

  • Updates the lib/napi submodule pointer from 8224dc35e95f… to f3d5335f8bbc….
  • (From PR description) Intended to restore correct process-exit propagation semantics for V8-imports callback trampolines, fixing test-tls-handshake-exception.

@Arshia001
Arshia001 force-pushed the eco-416-tls-handshake branch from dd51ecc to 0985808 Compare August 4, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants