Skip to content

fix: create parent dirs on CompleteMultipartUpload #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilyanni merged 1 commit into from
Jul 13, 2026
Merged

fix: create parent dirs on CompleteMultipartUpload #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/storages/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,12 @@ impl S3Storage for FileSystem {
};

let object_path = trace_try!(self.get_object_path(&bucket, &key));
// Create the key's parent dirs first, as put_object does; otherwise a

@theduke theduke Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are tests, please add a test for this.

@kilyanni kilyanni Jul 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry, I was a bit too fast on the merge there ^^'

Gonna add one

// prefixed key (e.g. simple/pkg/x.whl) fails File::create with
// NotFound and Complete returns 500.
if let Some(dir_path) = object_path.parent() {
trace_try!(fs::create_dir_all(&dir_path).await);
}
let file = trace_try!(File::create(&object_path).await);
let mut writer = BufWriter::new(file);

Expand Down
Loading