fix: create parent dirs on CompleteMultipartUpload - #8
Merged
Conversation
theduke
approved these changes
Jul 13, 2026
theduke
reviewed
Jul 13, 2026
| }; | ||
|
|
||
| let object_path = trace_try!(self.get_object_path(&bucket, &key)); | ||
| // Create the key's parent dirs first, as put_object does; otherwise a |
There was a problem hiding this comment.
I believe there are tests, please add a test for this.
Author
There was a problem hiding this comment.
oh, sorry, I was a bit too fast on the merge there ^^'
Gonna add one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complete_multipart_uploadassembled the object withFile::createbut, unlikeput_object, never created the key's parent directories. Any key with a prefix (e.g.simple/pkg/x.whl) therefore failed withNotFoundand the request returned 500 InternalError after the parts were already uploaded.Mirror
put_object:create_dir_allthe object's parent before writing.Verified against real rclone: a 6 MiB multipart upload to a prefixed key returns 500 before this change and succeeds after, with part temp files cleaned up.