Skip to content

Check protocols_used pins against the local dependency version - #48

Merged
lwaldron merged 1 commit into
mainfrom
pin-check
Oct 23, 2026
Merged

lwaldron merged 1 commit into
mainfrom
pin-check

Conversation

@lwaldron

Copy link
Copy Markdown
Member

Part of #36.

The validator confirmed that a same-repository dependency in protocols_used exists, but never compared the pin with the dependency's own version. A stale pin passed CI and failed later in the runner, at resolution time. This adds the comparison next to the existence check, with a test, and one sentence in the standard stating the rule. Dependencies in other repositories are still not checked.

The five pins in humann4-database-build match, so waldronlab/agent-protocols still validates.

🤖 Drafted with Claude Code

…version

The validator checked that a same-repository dependency exists but never
compared the pin against its version, so a stale pin passed CI and failed
in the runner at resolution time. Compare them, and say so in the standard.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

@lwaldron
lwaldron merged commit 29ea1da into main Oct 23, 2026
2 checks passed
@lwaldron
lwaldron deleted the pin-check branch October 23, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant