Skip to content

Update referenceId in deployment.yaml #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffersontuc merged 6 commits into from
Aug 6, 2026
Merged

Update referenceId in deployment.yaml #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b98294
Update referenceId in deployment.yaml
kevinch Jul 23, 2026
d30a1aa
chore: remove PLACEHOLDER referenceId, keep V5G7Q14G
kevinch Jul 23, 2026
a945009
ci: bump actions/cache v2 -> v4 (v2 is deprecated and now hard-fails)
kevinch Jul 24, 2026
666c885
ci: add nodeCommands to node-ci-v2 for coverage scan
kevinch Aug 4, 2026
b2e60c1
ci: skip install lifecycle scripts to avoid phantomjs-prebuilt download
kevinch Aug 5, 2026
b3a66a0
ci: install react/ deps before running its tests in test:coverage
kevinch Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- run: |
yarn install --frozen-lockfile --check-files
yarn --cwd react install --frozen-lockfile --check-files
- uses: actions/cache@v2
- uses: actions/cache@v4
id: cache-build
with:
path: ./*
Expand All @@ -30,7 +30,7 @@ jobs:
needs: install
steps:
- name: Restore cache
uses: actions/cache@v2
uses: actions/cache@v4
id: restore-build
with:
path: ./*
Expand All @@ -42,7 +42,7 @@ jobs:
needs: install
steps:
- name: Restore cache
uses: actions/cache@v2
uses: actions/cache@v4
id: restore-build
with:
path: ./*
Expand Down
4 changes: 3 additions & 1 deletion .vtex/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
- name: pickup-points-modal
referenceId: PLACEHOLDER
referenceId: V5G7Q14G
description: SonarQube scan for pickup-points-modal
build:
provider: dkcicd
Expand All @@ -8,6 +8,8 @@
parameters:
sonarProjectName: pickup-points-modal
nodeVersion: 20-bookworm
nodeCommands:
- run test:coverage
runtime:
architecture: amd64
when:
Expand Down
1 change: 1 addition & 0 deletions .yarnrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ignore-scripts true
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"lint:locales": "intl-equalizer",
"lint:ts": "tsc --noEmit -p react/tsconfig.json",
"test": "yarn --cwd react test",
"test:coverage": "yarn --cwd react test --coverage",
"test:coverage": "yarn --cwd react install --frozen-lockfile && yarn --cwd react test --coverage",
"test:watch": "yarn --cwd react test --watch",
"prepublishOnly": "npm run symlink:remove && npm run symlink && npm run build && npm run symlink:remove",
"build:link": "npm link && watch 'npm run build' src",
Expand Down
Loading