Skip to content

Update referenceId in deployment.yaml - #218

Merged
jeffersontuc merged 6 commits into
mainfrom
kevinch-patch-1
Aug 6, 2026
Merged

Update referenceId in deployment.yaml#218
jeffersontuc merged 6 commits into
mainfrom
kevinch-patch-1

Conversation

@kevinch

@kevinch kevinch commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

Updated referenceId for pickup-points-modal in deployment configuration.

Id taken here: https://darkkitchen.vtex.com/catalog/default/component/pickup-points-modal

What problem is this solving?

Misconfiguration.

Types of changes

  • Chore for DK

Updated referenceId for pickup-points-modal in deployment configuration.

Id taken here: https://darkkitchen.vtex.com/catalog/default/component/pickup-points-modal
@kevinch
kevinch requested a review from a team as a code owner July 23, 2026 16:53
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Jul 23, 2026

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-pr-sentinel

vtex-pr-sentinel Bot commented Jul 23, 2026

Copy link
Copy Markdown

🛡️ SDD Check — action required

I couldn't detect an SDD in this PR. Please check one option below (requires write access to the repo):

  • SDD lives in another PR — paste the SDD PR URL here:
  • This PR doesn't need an SDD
  • SDD applies, but I'm not adopting it in this PR

kevinch and others added 5 commits July 23, 2026 13:55
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Without nodeCommands, node-ci-v2 has no test step to run and Sonar
never gets coverage data.
phantomjs-prebuilt (pulled in transitively via nwb/karma-phantomjs-launcher,
unused by the actual jest tests) tries to download and tar-extract a
PhantomJS binary on postinstall. The CI image has no bzip2, so extraction
fails and node-install never completes. No compiled/native deps here need
install scripts to run.
node-ci-v2 only installs the root package.json; react/ has its own
yarn.lock and is not a workspace, so vtex-test-tools (a react/
devDependency) was never installed before test:coverage tried to run it.
@sonar-workflows

Copy link
Copy Markdown

Failed Quality Gate failed

  • 6065 New Issues (is greater than 0)
  • 0.00% Coverage on New Code (is less than 75.00%)
  • 25.28% Duplicated Lines (%) on New Code (is greater than 10.00%)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)
  • D Reliability Rating on New Code (is worse than A)

Project ID: pickup-points-modal

View in SonarQube

@kevinch
kevinch requested a review from ernestosbarbosa August 5, 2026 12:43

@ernestosbarbosa ernestosbarbosa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffersontuc
jeffersontuc merged commit 80f9156 into main Aug 6, 2026
13 of 30 checks passed
@jeffersontuc
jeffersontuc deleted the kevinch-patch-1 branch August 6, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants