Skip to content

PHPStan: Drop the booleanAnd.alwaysFalse ignore, unused since 2.2.6 - #1310

Merged
vrana merged 1 commit into
vrana:mainfrom
landsman:phpstan-unused-ignore
Aug 1, 2026
Merged

PHPStan: Drop the booleanAnd.alwaysFalse ignore, unused since 2.2.6#1310
vrana merged 1 commit into
vrana:mainfrom
landsman:phpstan-unused-ignore

Conversation

@landsman

@landsman landsman commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

CI is currently red on main itself, not just on pull requests:

Ignored error pattern booleanAnd.alwaysFalse was not matched in reported errors.
[ERROR] Found 1 error

No code reports booleanAnd.alwaysFalse any more, so the ignore in conf/phpstan.neon is unmatched and reportUnmatchedIgnoredErrors (on by default) fails the run.

Bisected against an unmodified checkout of 29623c3, same config, PHP 8.4:

PHPStan Result
2.2.5 [OK] No errors
2.2.6 [ERROR] Found 1 error
2.2.7 [ERROR] Found 1 error

With this line dropped, 2.2.7 gives [OK] No errors.

Nothing was committed to break it — php-actions/phpstan@v3 is used with version: latest, so the new PHPStan arrived on its own. Worth noting the workflow only triggers on pull_request and workflow_dispatch, so a red main is invisible until someone opens a PR.

If you would rather this could not happen again, pinning the PHPStan version in .github/workflows/ci.yml would do it, but that is your call and not in this change.

@vrana
vrana merged commit 422177c into vrana:main Aug 1, 2026
1 check passed
@vrana

vrana commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Thanks, I've also pinned PHPStan to 2.2.7 so that this doesn't happen in the future.

@landsman
landsman deleted the phpstan-unused-ignore branch August 3, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants