PHPStan: Drop the booleanAnd.alwaysFalse ignore, unused since 2.2.6 - #1310
Merged
Conversation
Owner
|
Thanks, I've also pinned PHPStan to 2.2.7 so that this doesn't happen in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is currently red on
mainitself, not just on pull requests:No code reports
booleanAnd.alwaysFalseany more, so the ignore inconf/phpstan.neonis unmatched andreportUnmatchedIgnoredErrors(on by default) fails the run.Bisected against an unmodified checkout of 29623c3, same config, PHP 8.4:
[OK] No errors[ERROR] Found 1 error[ERROR] Found 1 errorWith this line dropped, 2.2.7 gives
[OK] No errors.Nothing was committed to break it —
php-actions/phpstan@v3is used withversion: latest, so the new PHPStan arrived on its own. Worth noting the workflow only triggers onpull_requestandworkflow_dispatch, so a redmainis invisible until someone opens a PR.If you would rather this could not happen again, pinning the PHPStan version in
.github/workflows/ci.ymlwould do it, but that is your call and not in this change.