before-unload: the page is being left, not reloaded (cs, de) - #1309
Merged
Conversation
Contributor
Author
|
The red CI here is not from this change. PHPStan only analyses It arrived with PHPStan 2.2.6 (2.2.5 is green on the same tree) and #1310 fixes it in one line and its own run is green. Happy to rebase this branch once that lands so the check here goes green too. |
Owner
|
Thanks and sorry about the CI error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description of the before-unload plugin says the confirmation appears before the page is reloaded in German, which is narrower than what the code does:
onbeforeunloadfires whenever the page goes away — closing the tab, navigating elsewhere, or a reload.The English doc-comment,
hrandplare correct and untouched.jareads "before reloading the page" (再読込み) too, so it may want the same fix, but I do not speak Japanese well enough to propose the wording.