backlog: track reaction-prompt-i18n#39
Merged
Merged
Conversation
The opportunity-attack reaction modal is entirely English under DND_LANGUAGE=ru. round.py:446 builds ReactionOption.description as an f-string outside gettext, reaction_to_dict passes it through raw (unlike the adjacent action description, which is wrapped in _()), and ReactionPrompt.tsx renders it as-is. Found by the full docs review while closing sprint 024, not by E2E — no scenario covers the language of this modal.
vladmesh
enabled auto-merge
July 16, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files the one finding from sprint 024's full docs review that was not already tracked.
The opportunity-attack reaction modal is entirely English under
DND_LANGUAGE=ru("Melee attack against Wolf"). Verified end to end:round.py:446buildsReactionOption.descriptionas an f-string outside gettext (round.pyimports no i18n at all)reaction_to_dict(transport_payloads.py:109) passesoption.descriptionthrough raw, unlike the adjacent line 52 which wraps_(definition.description)ReactionPrompt.tsx:32renders it as-isWrapping
_()at the transport layer will not work: the target name is already interpolated, so the msgid won't match. The fix is either to build the string through_()with a placeholder at construction time, or to pass a template plus params and assemble on the client by i18n key (the approach sprint 024 used for itemprops).Filed as should rather than could like its sibling
movement-log-i18n: this isn't a log line, it's the entire text of an interactive modal that blocks the player's turn.Found by
/update-docsduring sprint 024 closure, not by E2E — no scenario covers this modal's language. Docs-only change.