backlog: fix reaction-prompt-i18n snippet to project convention#40
Merged
Conversation
The suggested snippet used %-interpolation; the codebase uses
_("... {id} ...").format(id=...) and the .po msgids carry {} placeholders.
Also spell out why wrapping _() at transport fails silently: fallback=True
returns the msgid unchanged, and pygettext cannot extract from an f-string.
vladmesh
enabled auto-merge
July 16, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39. The entry suggested
%-interpolation:That works, but contradicts the codebase: handlers use
_("Item {id} not in inventory").format(id=item_id)and the.pomsgids carry{}placeholders. Left as-is it would send whoever picks this up down the wrong path. Now:Also spells out why wrapping
_()at the transport layer fails, which the original entry only asserted:fallback=Trueini18n.pymeans a missed msgid returns the input string unchanged, silently — no error, tests stay green, the player sees English_(), so there is nothing to extract from an f-string;make messagesadditionally falls over on f-strings_()resolves via thecurrent_langcontextvar (per-session), which a transport-layer wrap would not giveDocs-only change.