Skip to content

feat(tables): add first-class fixed-size-list GPU columns - #3015

Open
ibgreen-openai wants to merge 3 commits into
codex/luvs-command-graph-aliasingfrom
codex/luvs-fixed-size-list-landing
Open

feat(tables): add first-class fixed-size-list GPU columns#3015
ibgreen-openai wants to merge 3 commits into
codex/luvs-command-graph-aliasingfrom
codex/luvs-fixed-size-list-landing

Conversation

@ibgreen-openai

Copy link
Copy Markdown
Collaborator

Goals

Add first-class fixed-size GPU table columns such as fixed-size-list<float32,768> without introducing a second embedding-specific storage owner.

Changes

  • Add the public FixedSizeList<Format, Size> type and canonical fixed-size-list format decoding.
  • Preserve logical row counts, flattened coordinate counts, padded rows, existing chunk/batch boundaries, and GPUData ownership.
  • Keep fixed-size-list storage distinct from vertex attributes and validate actual storage-binding spans.
  • Document GPU table format, schema, vector, data, lifecycle, and explicit packing semantics.
  • Cover widths 384/768/1536, empty rows, padding, ownership, explicit attribute expansion, and safe nullable packing.

Previously reviewed as #3007. This is the clean landing PR based on the graph prerequisite; merge only after #2943 lands in master.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0190f61351

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/tables/src/engine/gpu-table-computation.ts Outdated
Comment thread modules/tables/src/table/gpu-table.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants