Repository navigation
Fix stale sync claim ownership - #23
Merged
Merged
Conversation
vicentereig
force-pushed
the
codex/fix-stale-sync-claim-ownership
branch
from
July 5, 2026 15:17
ec9802d to
fb27193
Compare
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stale-claim ownership scenario that came out of the review on #20.
@hxu this is the follow-up I mentioned: once an
in_progresstask can be recovered as stale and claimed again, the old worker must not be able to complete or fail the newer claim by task id alone.The first version of this PR fenced the final
completed/failedtransition with(task_id, claim_attempt). The review tightened the invariant: the claim token has to cover the whole compound action that creates durable queue effects.Scenario covered:
Changes:
SyncData.complete source task + enqueue follow-up tasks.Validation:
cargo fmt --all -- --checkcargo test -p garmin-cli stale_claimcargo test -p garmin-clicargo clippy --all-targets --all-features -- -D warnings