Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
# and was merged untested. Every PR gets the full suite; push stays main-only so
# feature branches do not double-run.
pull_request:
branches: [main]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep CI enabled for stacked pull requests

Remove this base-branch filter: when a pull request targets another feature branch instead of main, GitHub does not start this workflow, so its format, lint, build, unit, and installer E2E checks can again be bypassed. This directly reintroduces the untested stacked-PR scenario documented immediately above the trigger; adding merge_group does not compensate because that event only applies after a PR enters the merge queue for the protected branch.

Useful? React with 👍 / 👎.

merge_group:
types: [checks_requested]
push:
branches: [main]

Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/semantic-pr-title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@ name: Semantic PR Title
on:
pull_request:
types: [opened, edited, synchronize, reopened]
merge_group:
types: [checks_requested]

permissions:
pull-requests: read

jobs:
semantic-pr-title:
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v6
Expand All @@ -27,3 +30,10 @@ jobs:
perf
revert
requireScope: false

semantic-pr-title-merge-group:
if: github.event_name == 'merge_group'
name: semantic-pr-title
runs-on: ubuntu-latest
steps:
- run: echo 'PR title was validated before this merge-group run.'
Loading