ci: support merge queue checks - #178
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c7a3c69f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # and was merged untested. Every PR gets the full suite; push stays main-only so | ||
| # feature branches do not double-run. | ||
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
Remove this base-branch filter: when a pull request targets another feature branch instead of main, GitHub does not start this workflow, so its format, lint, build, unit, and installer E2E checks can again be bypassed. This directly reintroduces the untested stacked-PR scenario documented immediately above the trigger; adding merge_group does not compensate because that event only applies after a PR enters the merge queue for the protected branch.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
ruby -e "require "yaml"; ARGV.each { |p| YAML.load_file(p) }" .github/workflows/ci.yml .github/workflows/semantic-pr-title.ymlgit diff --checkNo merge-queue rule is enabled until this workflow support is on
main.