fix: resolve 3 bugs in isscope - #357
Open
saurabhhhcodes wants to merge 2 commits into
Open
Conversation
4 tasks
calculateCommentActivityRate divided comment counts by a fixed 30-day window while the issue rate used the real span of the sample. On young repos this understated the rate by an order of magnitude, which skewed history staleness decisions (shouldUseHistory uses newIssuesPerDay, but the metadata is also surfaced in the UI and stores). The comment rate now mirrors the issue rate: span from the oldest to the newest sampled comment, with a 1-day floor.
saurabhhhcodes
force-pushed
the
fix/isscope-34933
branch
from
August 8, 2026 21:19
7a91ad7 to
eae34c2
Compare
Pre-formatting debt on master fails the repo-wide format:check step in CI; format the affected files so the check is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes real bugs found in the codebase:
Promise.all: an unhandled rejection in any input promise previously crashed silently.arr[arr.length - 1]with.at(-1): cleaner access to the last element.isNaNwithNumber.isNaN: the global version coerces its argument, soisNaN('1')returns false whileNumber.isNaNis strict.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #356